Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add edited callback for SpinBox #3096

Merged
merged 3 commits into from Jul 18, 2023
Merged

Add edited callback for SpinBox #3096

merged 3 commits into from Jul 18, 2023

Conversation

darknight
Copy link
Contributor

This PR is for #3054

Add edited callback similar to LineEdit component, for different three styles: native, fluent & material.

@CLAassistant
Copy link

CLAassistant commented Jul 17, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@ogoffart ogoffart requested a review from FloVanGH July 17, 2023 13:43
FloVanGH
FloVanGH reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@FloVanGH FloVanGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the PR looks good to me. Thank you.

internal/compiler/builtins.slint Outdated Show resolved Hide resolved
internal/compiler/widgets/fluent-base/spinbox.slint Outdated Show resolved Hide resolved
@FloVanGH FloVanGH mentioned this pull request Jul 17, 2023
Closed
@FloVanGH
Copy link
Member

Thank you looks good.

@FloVanGH FloVanGH merged commit 1b0d3b1 into slint-ui:master Jul 18, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloVanGH FloVanGH FloVanGH left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@darknight @CLAassistant @FloVanGH