Fixed text input on fluent and material SpinBox #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
reviewed
Jul 18, 2023
tronical
reviewed
Jul 18, 2023
| @@ -14,6 +14,7 @@ All notable changes to this project are documented in this file. | |||
|
|
|||
| - In case of error, still attempt to run more pass to report more diagnostics | |||
| - Fixed compiler panic when an unresolved alias has a binding | |||
| - Added `edited` callback to `SpinBox` | |||
There was a problem hiding this comment.
It doesn't look like that this PR adds the edited callback. Is this intentional here?
There was a problem hiding this comment.
The edited callback is merged. For completeness I used this PR to add it to the change log. I can also add it with a separate commit on master
There was a problem hiding this comment.
No, I think that's fine :). I was just curious. It would be really great to also have documentation for the new callback though (otherwise it doesn't exist for our users :-)
tronical
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.