Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Rework item geometry #3115

Closed
wants to merge 15 commits into from
Closed

Draft: Rework item geometry #3115

wants to merge 15 commits into from

Commits on Jul 24, 2023

  1. Flickable: don't make the viewport special 

    Instead: add the viewport propety directly in the Flickable

Simplifies the compiler's code generation a bit
    @ogoffart @Guiguiprim
    ogoffart authored and Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    582a7a3 View commit details
    Browse the repository at this point in the history

  2. WIP: Add item_geometry to the ComponentVTable 

    (unused yet)
    @ogoffart @Guiguiprim
    ogoffart authored and Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    f6383fa View commit details
    Browse the repository at this point in the history

  3. Use the item_geometry from ComponentVTable

    @ogoffart @Guiguiprim
    ogoffart authored and Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c15ddc4 View commit details
    Browse the repository at this point in the history

  4. Fix computation of the item sub range 

    We need to account for the repeater count in the item sub-range
    @ogoffart @Guiguiprim
    ogoffart authored and Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    7fcb123 View commit details
    Browse the repository at this point in the history

  5. Fix generation of geometry prop for some primitives

    @ogoffart @Guiguiprim
    ogoffart authored and Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    b6fe5c6 View commit details
    Browse the repository at this point in the history

  6. More use of item_geometry

    @ogoffart @Guiguiprim
    ogoffart authored and Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    1da9b0d View commit details
    Browse the repository at this point in the history

  7. Fix PopupWindow positioning 

    The WindowItem did not have a x or y before, so these property
were unused for it's geometry(), but now it is used in the new
item_geometry on the ComponentVTable.
So make sure we don't initialize them
    @ogoffart @Guiguiprim
    ogoffart authored and Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    f517cd3 View commit details
    Browse the repository at this point in the history

  8. Remove the geometry on ItemVTable

    @ogoffart @Guiguiprim
    ogoffart authored and Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    1d60a00 View commit details
    Browse the repository at this point in the history

  9. Remove duplicated geometry properties from items

    @Guiguiprim
    Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    5444cdd View commit details
    Browse the repository at this point in the history

  10. include geometries in Element debug print

    @Guiguiprim
    Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    a0c51e3 View commit details
    Browse the repository at this point in the history

  11. fix item_tree test compilation

    @Guiguiprim
    Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    713127c View commit details
    Browse the repository at this point in the history

  12. fix resolve_native_classes pass

    @Guiguiprim
    Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    f7dce18 View commit details
    Browse the repository at this point in the history

  13. fix lower_shadow: correctly create ElementRc 

    I would love to add a clippy disallowed method for this, but it's a
generic type alias.
    @Guiguiprim
    Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    238b2b2 View commit details
    Browse the repository at this point in the history

  14. WIP Take new geometry into account in useless_rectangle

    @Guiguiprim
    Guiguiprim committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    aad9133 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. WIP Take new geometry into account in useless_rectangle

    @Guiguiprim
    Guiguiprim committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    930be7e View commit details
    Browse the repository at this point in the history