Added set_fullscreen API to WindowAdapter.
#4286
Conversation
|
|
qhua948
force-pushed
the
fullscreen-toggle
branch
2 times, most recently
from
41a3195
to
991b11a
Compare
| @@ -203,11 +203,6 @@ impl WinitWindowAdapter { | |||
| let mut window_builder = | |||
| winit::window::WindowBuilder::new().with_transparent(true).with_visible(false); | |||
|
|
|||
| if std::env::var("SLINT_FULLSCREEN").is_ok() { | |||
There was a problem hiding this comment.
I'm thinking we should keep the env variable for now in addition, or that'd be a breaking change.
internal/backends/qt/qt_window.rs
Outdated
| if (fullscreen) { | ||
| widget_ptr->setWindowState(Qt::WindowFullScreen); | ||
| } else { | ||
| widget_ptr->setWindowState(Qt::WindowNoState); | ||
| } | ||
| } |
There was a problem hiding this comment.
This would also clear other states like minimized and maximized.
In fact, the best would be to add or remove the Qt::WindowFullScreen flag from the set of state using windowStates and setWindowStates
There was a problem hiding this comment.
That makes a lot of sense, done.
|
The C++ formatting is broken:-/ Could you please consider to fix that? Unfortunately github will not push fix suggestions into other people's branches, so unfortunately you can not just accept that :-) And neither can I do it for you as I can not push an update into your branch either. |
qhua948
force-pushed
the
fullscreen-toggle
branch
2 times, most recently
from
690b6c3
to
84acb51
Compare
Just ran clang-format :3 |
qhua948
force-pushed
the
fullscreen-toggle
branch
5 times, most recently
from
79d9b59
to
7ab4869
Compare
env var and related docs. Use `QWindow::setWindowStates()` to set the fullscreen state for Qt backend.
qhua948
force-pushed
the
fullscreen-toggle
branch
from
a8801b1
to
6914868
Compare
|
I was looking for examples/fullscreen_toggle/ git describe --tags None of the above is visible to me. git clone https://github.com/slint-ui/slint nothing to commit, working tree clean fullscreen_toggle directory in examples is still not there. I don't understand. I thought this was committed and part of master. |
|
I just went to the details for this merge/commit. Am I blind? What were those builds and tests using to evaluate that it passed? |
|
The example was removed at the request of the maintainers before the merge, but you should be able to find the commit hash and use that.
----------------------------------------
Mar 6, 2024 23:32:12 David Marceau ***@***.***>:
…
I just went to the details for this merge/commit.
https://github.com/slint-ui/slint/actions/runs/7456944726/job/20288395478
I don't see anywhere in those details mentioning it building fullscreen_toggle.
Am I blind? What were those builds and tests using to evaluate that it passed?
—
Reply to this email directly, view it on GitHub[#4286 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AFZFMUZ3IZ2SAYOWQNAMQQ3YW4EEXAVCNFSM6AAAAABBQXQYSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBQG43DSNRQGI].
You are receiving this because you authored the thread.
[Tracking image][https://github.com/notifications/beacon/AFZFMUYYWRBC2QJDJD3FS3TYW4EEXA5CNFSM6AAAAABBQXQYSWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTWCASUE.gif]
|
This PR exposes the fullscreen API for both winit and qt to
WindowAdapterwhich can be called from client code to set or unset fullscreen status.Removed inflexible env variable
SLINT_FULLSCREENand instead use the new API to set fullscreen status.Added an example application
examples/fullscreen_toggleto demo the toggle.Note that this is a breaking change, if the maintainer believes that the environment variable should be kept, then I am happy to amend this as well.
See #3283