live preview: Add in new components #5428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and make it trigger a function in preview.rs.
|
This is the current UI
The position of the button is strange. I think it shouldn't be within the list, but outside the list. Possibly in the toolbar. Currently, clicking on that button adds a component call "MyComponent" in the view (the screen shot i clicked 3 times on it) but it doesn't focus the editor on it and clicking on it in the view also don't focus the editor on it so it is very confusing. I think we should wait until this is usable before merging this, or hide it under the experimental env variable. |
ogoffart
reviewed
Jun 18, 2024
Co-authored-by: Olivier Goffart <olivier.goffart@slint.dev>
hunger
force-pushed
the
push-wqswzoxrzpvs
branch
from
41bc6d3
to
7a4812b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The component can not yet get renamed via the UI, that's up next.