New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add math funcs Log10, Log2, Log and Exp #813
Conversation
Great change, thanks! I wonder if we really need log2 and log10 if we can use log(foo, 2) and log(bar, 10). Also I think exp should take a parameter with the exponent. |
I realize that C++ and rust and JavaScript calls the exp function with an arbitrary base "pow". So we should have this function as well. |
I'd lean towards removing |
Looks good, thank you. |
Ah, it is still missing the documentation in langref.md |
There we go. That should be all of it (hopefully the changelog entry looks fine) |
Perfect, thanks! |
Fixes #755
I'm not sure if the Log10 and Log2 functions need to stay but I added them because both c++ and rust have them as a standard.