Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting multiValueHeaders #65

Merged
merged 3 commits into from May 11, 2020
Merged

Supporting multiValueHeaders #65

merged 3 commits into from May 11, 2020

Conversation

amacks
Copy link
Contributor

@amacks amacks commented May 7, 2020

  • This is to hopefully support multiValueHeaders in the response JSON for ALB.
  • The code should only send one of headers or multiValueHeaders
  • I added a test case verifying the new field, and all old code should work as before (test cases pass)
  • Formatting was updated to match the black rules

@thomasthiebaud
Copy link

Thanks for your contribution, we will have a look at it early next week

@sloev
Copy link
Owner

sloev commented May 11, 2020

fixes #64

@sloev sloev merged commit d8250e3 into sloev:master May 11, 2020
@sloev sloev mentioned this pull request May 11, 2020
Closed
@sloev
Copy link
Owner

sloev commented May 11, 2020

@amacks your additions have been released, check out v9.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amacks @thomasthiebaud @sloev