You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note that syslog::Logger::send_raw returns the number of bytes written from the RFC3164 formatted message and not the raw message passed to it, so using the count returned by send is not suitable for trimming TL_BUF.
Streamer3164 should probably use format_3164 directly and continuously call send_raw until the message is fully written. Drain::log feels like std::io::Write::write_all to me, so I think this is semantically appropriate.
The text was updated successfully, but these errors were encountered:
whipsch
added a commit
to whipsch/slog-rs
that referenced
this issue
Sep 29, 2016
The
Drain::log
implementation forStreamer3164
never trimsTL_BUF
after writing some bytes from it viasyslog::Logger::send
.Note that
syslog::Logger::send_raw
returns the number of bytes written from the RFC3164 formatted message and not the raw message passed to it, so using the count returned bysend
is not suitable for trimmingTL_BUF
.Streamer3164
should probably useformat_3164
directly and continuously callsend_raw
until the message is fully written.Drain::log
feels likestd::io::Write::write_all
to me, so I think this is semantically appropriate.The text was updated successfully, but these errors were encountered: