New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore sockets when loading keys #102
Conversation
If a user uses ControlMaster in OpenSSH, UNIX sockets often appear in their ~/.ssh directory. These fail loading as a key. This skips those sockets in the filesystem. Fixes slok#101.
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 80.92% 80.49% -0.43%
==========================================
Files 16 16
Lines 1227 1241 +14
==========================================
+ Hits 993 999 +6
- Misses 173 179 +6
- Partials 61 63 +2
Continue to review full report at Codecov.
|
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Matir! Thanks for the contribution! I didn't have this case myself, so I appreciate a lot the use case you found.
I fixed the linting and add some tests. Should be ready to be merged
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
If a user uses ControlMaster in OpenSSH, UNIX sockets often appear in their ~/.ssh directory. These fail loading as a key. This skips those sockets in the filesystem.
Fixes #101.