Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example with gin does not work properly #31

Closed
yechongbo opened this issue Apr 18, 2020 · 3 comments · Fixed by #38
Closed

example with gin does not work properly #31

yechongbo opened this issue Apr 18, 2020 · 3 comments · Fixed by #38
Assignees
@slok
Labels
bug Something isn't working

Comments

@yechongbo
Copy link

with the response type as json, it produces two items in output.
@slok slok self-assigned this Apr 18, 2020
@slok slok added the bug Something isn't working label Apr 18, 2020
@slok
Copy link
Owner

slok commented Apr 18, 2020

Hi @yechongbo thanks for opening the issue! I'll try to take a look this week

@fungiboletus
Copy link

Meanwhile, using the default example with http.Handler works fine.

@slok slok mentioned this issue May 31, 2020
Merged
@slok slok closed this as completed in #38 May 31, 2020
@slok
Copy link
Owner

slok commented Jun 2, 2020

Hi @yechongbo and @fungiboletus!

I just published a new release that has the fix that was merged some days ago: https://github.com/slok/go-http-metrics/releases/tag/v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slok slok

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor internal Middleware slok/go-http-metrics
3 participants
@fungiboletus @slok @yechongbo