Refactor internal Middleware #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
…ementations Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Return to the past API so we don't break all libraries/framework implementations
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Add more requests in integration tests
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how
Middlewareservice works. NowMiddlewareis not an interface and doesn't return a Handler.Middlewarestruct now has a method called Measure that will receive aReporter, this instance knows how to return the data required to be measure, this means that every different framework/library will need to implement theReporterbased on the lib/framework request/response implementation.Apart from this, now the standard middleware
http.Handleris understdin the same way the other lib/frameworks work.This refactor has fixed some implementation issues.
Also, integration tests have been added.
Fixes #31