Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes storage ID validation #180

Merged
merged 2 commits into from Oct 30, 2020
Merged

Add Kubernetes storage ID validation #180

merged 2 commits into from Oct 30, 2020

Conversation

slok
Copy link
Owner

@slok slok commented Oct 29, 2020

Closes #179

Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #180 into master will increase coverage by 0.87%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   75.77%   76.65%   +0.87%     
==========================================
  Files          27       27              
  Lines        1218     1221       +3     
==========================================
+ Hits          923      936      +13     
+ Misses        218      213       -5     
+ Partials       77       72       -5     
Impacted Files Coverage Δ
internal/storage/kubernetes/kubernetes.go 92.30% <100.00%> (+8.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c95b51...cdd5aa8. Read the comment docs.

@slok slok merged commit 5aa65d8 into master Oct 30, 2020
@slok slok deleted the slok/validate-storage-id branch October 30, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes storage ID should be validated
2 participants