Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deployment via Helm to kube 1.19 clusters #161

Merged
merged 3 commits into from Sep 25, 2021

Conversation

xairos
Copy link
Contributor

@xairos xairos commented Sep 23, 2021

First, thank you for the Sloth project! This kind of tool is sorely needed to take much of the toil out of generating SLO-based metrics, visualizations, and alerts 馃榾

We want to use the Helm deploy method and would love to stay in sync with upstream, but are running a 1.19 cluster at the moment.

score-sloth                       sloth                              False   Helm install failed: chart requires kubeVersion: >= 1.20.0 which is incompatible with Kubernetes v1.19.12-gke.2101   17h

This change would relax the chart's version restriction by a minor kube version. It seemed like this wouldn't be problematic, since CI already tests against kube 1.19?

strategy:
matrix:
kubernetes: [1.19.11, 1.20.7, 1.21.1, 1.22.0]

@xairos xairos requested a review from slok as a code owner September 23, 2021 14:33
Copy link
Owner

@slok slok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xairos, Thanks for the PR! it makes sense :)

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #161 (ca41c8c) into main (3f0d37f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   78.10%   78.10%           
=======================================
  Files          16       16           
  Lines        1311     1311           
=======================================
  Hits         1024     1024           
  Misses        233      233           
  Partials       54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3f0d37f...ca41c8c. Read the comment docs.

@slok
Copy link
Owner

slok commented Sep 25, 2021

@xairos the Helm tests are failing, could you fix them, please 馃槃 ?

Here are the expected outputs that don't match: https://github.com/slok/sloth/tree/main/deploy/kubernetes/helm/tests/testdata/output

@slok slok merged commit 0c4d2b5 into slok:main Sep 25, 2021
@slok
Copy link
Owner

slok commented Sep 25, 2021

Awesome! Many thanks!

@xairos
Copy link
Contributor Author

xairos commented Sep 25, 2021

Fantastic, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants