fix create from format with invalid format #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_from_format('d/m/Y', '2022-05-28')
return false instead of throwing an exception
asprega
requested changes
Aug 21, 2023
src/ClockMock.php
Outdated
| @@ -223,7 +223,13 @@ public static function mock_date_create_immutable_from_format(): callable | |||
| // Create an immutable instance starting from the mutable mock, so we don't have to replicate mocking logic. | |||
| $mutableDateTime = date_create_from_format($format, $datetime, $timezone); | |||
|
|
|||
| return new \DateTimeImmutable($mutableDateTime->format('Y-m-d\TH:i:s.u'), $mutableDateTime->getTimezone()); | |||
| return $mutableDateTime | |||
There was a problem hiding this comment.
instead of treating a valid date object like a truthy value in a ternary statement, I believe it would be more explicit to make an early return if the return value from date_create_from_format is false, like that:
if ($mutableDateTime === false) {
return false;
}
Also, a line with a comment saying that this variable can be false in case of invalid format would help.
|
Thanks! Released in 0.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g : date_create_immutable_from_format('d/m/Y', '2022-05-28')
return false instead of throwing an exception