Add argument raise_error_if_not_found for read_env

[reorx]

• raise IOError when env file not found, this is an essential feature for serious deployment that should not run when the file is missing
• print if env file is found or not when verbose=True

[sloria]

I'd rather not add this API surface for this. It's simple to do a check before running .read_env, if necessary.

from pathlib import Path
from environs import Env

env = Env()
if not Path(".env").exists():
    raise IOError("Missing .env file")
env.read_env(".env")

[reorx]

I don’t think so, the .env file is the dependency of Env class, it is okey to silently fail, but it is also necessary to provide a way to explicitly check the existence of the env file, otherwise it would be very difficult to find out when the file is mistakenly put. Yes you can make it with a few lines of code, but that doesn’t mean it’s a right choice not to include it in the library.

On Sun, Nov 1, 2020 at 07:05 Steven Loria ***@***.***> wrote: I'd rather not add this API surface for this. It's simple to do a check before running .read_env, if necessary. from pathlib import Pathfrom environs import Env env = Env()if not Path(".env").exists(): raise IOError("Missing .env file")env.read_env(".env") — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#165 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADDDVGC3ZKIXOGTFSEX7ZDSNSJ2NANCNFSM4PW4SNZQ> .

-- 青松虽苦寒，羞逐桃李春

[sloria]

I think this is something I'd rather follow python-dotenv's lead on. If python-dotenv adds behavior to raise on a missing file, I'd be more willing to add it to environs.

It looks like there have been attempts to add such an API, but nothing has landed yet.

theskumar/python-dotenv#164
theskumar/python-dotenv#263

[reorx]

You’re right, actually I was surprised python-dotenv didn’t implement it at the beginning, but my habit is to complete the missing feature, or correct the misbehaving one in higher level library, so just through the issue here :)

On Sun, Nov 1, 2020 at 12:04 Steven Loria ***@***.***> wrote: I think this is something I'd rather follow python-dotenv's lead on. If python-dotenv adds behavior to raise on a missing file, I'd be more willing to add it to environs. It looks like there have been attempts to add such an API, but nothing has landed yet. theskumar/python-dotenv#164 <theskumar/python-dotenv#164> theskumar/python-dotenv#263 <theskumar/python-dotenv#263> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#165 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADDDVG56EQQISYJKHK2S4DSNTM5PANCNFSM4PW4SNZQ> .

-- 青松虽苦寒，羞逐桃李春

[rptaylor]

@reorx now there is #311 for this instead.