Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs update for aiohttp 2.0 #3

Closed
patrick-jones opened this issue Mar 31, 2017 · 2 comments · Fixed by #5
Closed

Needs update for aiohttp 2.0 #3

patrick-jones opened this issue Mar 31, 2017 · 2 comments · Fixed by #5
Labels
help wanted

Comments

@patrick-jones
Copy link

Apparently there are backwards-incompatible changes in aiohttp 2.0. At the very least, you can no longer import web_reqgrep from aiohttp as in done here.
@sloria
Copy link
Owner

sloria commented Apr 1, 2017

Thanks @patrick-jones . I would certainly review and merge a PR fixing 2.0 compatibility. =)

underyx added a commit to underyx/webtest-aiohttp that referenced this issue Jul 27, 2017
@underyx
Access Request and StreamResponse via the public API
bb54f05 
`aiohttp.web_reqrep` seems to be private and was changed in aiohttp 2.0

Closes sloria#3
@underyx underyx mentioned this issue Jul 27, 2017
Closed
underyx added a commit to underyx/webtest-aiohttp that referenced this issue Jul 27, 2017
@underyx
Access Request and StreamResponse via the public API
52fb7c7 
`aiohttp.web_reqrep` seems to be private and was changed in aiohttp 2.0

Closes sloria#3
underyx added a commit to underyx/webtest-aiohttp that referenced this issue Jul 27, 2017
@underyx
Access Request and StreamResponse via the public API
bd0fdec 
`aiohttp.web_reqrep` seems to be private and was changed in aiohttp 2.0

Closes sloria#3
sloria added a commit that referenced this issue Feb 8, 2018
@sloria
Make compatible with aiohttp 2
f3a0bcf 
close #3
sloria added a commit that referenced this issue Feb 8, 2018
@sloria
Make compatible with aiohttp 2
8da4f26 
close #3
sloria added a commit that referenced this issue Feb 8, 2018
@sloria
Make compatible with aiohttp 2
45c5b06 
close #3
sloria added a commit that referenced this issue Feb 8, 2018
@sloria
Make compatible with aiohttp 2
26ad35d 
close #3
@sloria sloria mentioned this issue Feb 8, 2018
Merged
@sloria sloria closed this as completed in #5 Feb 8, 2018
@sloria
Copy link
Owner

sloria commented Feb 8, 2018

webtest-aiohttp 2.0.0 now supports aiohttp 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make compatible with aiohttp 2 sloria/webtest-aiohttp
2 participants
@sloria @patrick-jones