Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twig support #6

Closed
ruudk opened this issue Jun 17, 2013 · 3 comments
Closed

Twig support #6

ruudk opened this issue Jun 17, 2013 · 3 comments

Comments

@ruudk
Copy link
Contributor

ruudk commented Jun 17, 2013

I really want Twig support like https://github.com/ruudk/postmarkbundle#twig-templates

If I submit a PR would you merge it? Or is it out of the scope of this bundle?

Also, what do you think about the optional Resque support: https://github.com/ruudk/postmarkbundle#resque? I'm willing to submit a PR for this as well.

@slot
Copy link
Owner

slot commented Jun 17, 2013

Hi @ruudk,

it's probably outside of its scope, but I am totally fine with adding more logic to this bundle, that makes it even easier to use it.

Feel free to submit you PR.

Please keep in mind that this bundle might run on the console as well (as it does in our case) so as templating might be not available. Further there might be people out there who do not use all standard Symfony Bundles like Twig. You should design your code to be as fault tolerant as possible, if templating is not supported.

Best,
Sven

@hackzilla
Copy link

I think this is also beyond the scope, and it's easy to do in your controller.

$html = $container->get('templating')->render('AcmeBundle:EmailTemplates:acme_sales', array(
   'salutation' => $salutation,
   'date' => '2013-06-01',
));

@slot
Copy link
Owner

slot commented Jul 12, 2013

@ruudk feel free to provide a PR with your proposal. Closed for now.

@slot slot closed this as completed Jul 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants