-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twig support #6
Comments
Hi @ruudk, it's probably outside of its scope, but I am totally fine with adding more logic to this bundle, that makes it even easier to use it. Feel free to submit you PR. Please keep in mind that this bundle might run on the console as well (as it does in our case) so as templating might be not available. Further there might be people out there who do not use all standard Symfony Bundles like Twig. You should design your code to be as fault tolerant as possible, if templating is not supported. Best, |
I think this is also beyond the scope, and it's easy to do in your controller. $html = $container->get('templating')->render('AcmeBundle:EmailTemplates:acme_sales', array(
'salutation' => $salutation,
'date' => '2013-06-01',
)); |
@ruudk feel free to provide a PR with your proposal. Closed for now. |
I really want Twig support like https://github.com/ruudk/postmarkbundle#twig-templates
If I submit a PR would you merge it? Or is it out of the scope of this bundle?
Also, what do you think about the optional Resque support: https://github.com/ruudk/postmarkbundle#resque? I'm willing to submit a PR for this as well.
The text was updated successfully, but these errors were encountered: