ci: add .deb .rpm builds in containers, update package script #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xseman
commented
Dec 25, 2023
jsuchal
reviewed
Dec 27, 2023
jsuchal
reviewed
Dec 27, 2023
xseman
commented
Dec 27, 2023
xseman
commented
Dec 27, 2023
| - name: Build artifact | ||
| run: | | ||
| git config --global --add safe.directory ${GITHUB_WORKSPACE} | ||
| ./mvnw versions:set -DnewVersion=$(git describe --tags --abbrev=0 | sed -r 's/^v//g') |
There was a problem hiding this comment.
Tuto som vždy dostával v1.0.0, no myslím že to bolo kôli tomu, že fork nemá žiadne pushnute tagy
|
@celuchmarek vies si toto zobrat? |
celuchmarek
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#213
Pridal som build artifactov v Debian a Fedora kontajneroch, mám pocit že je to najjednoduchšie riešenie ako sa vyhnúť špeciálnym rozdielom v defaultoch distribúcií s jpackage a rpm.
Zatiaľ som neriešil cache alebo nejakú špecialnu optimalizáciu CI zbytočnou abstrakciou, build je relatívne rýchli a release sa nerobí tak často.
Refaktorol som package script aby bol konzistentnejší a pridal štandardnejšiu detekciu distribucie.