Refactor 2022-2023 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabomichal
reviewed
Mar 6, 2023
sabomichal
reviewed
Mar 6, 2023
sabomichal
reviewed
Mar 6, 2023
sabomichal
reviewed
Mar 6, 2023
|
Vseobecne:
|
sabomichal
reviewed
Mar 6, 2023
sabomichal
reviewed
Mar 6, 2023
sabomichal
reviewed
Mar 6, 2023
sabomichal
reviewed
Mar 6, 2023
Go 83/refactor
Go 92/fix card change bug
…s-to-autogram rename remaining files to Autorgam
…nd-errors Error stavy z API
sabomichal
reviewed
Apr 24, 2023
src/main/java/digital/slovensko/autogram/server/dto/SignRequestBody.java
Show resolved
Hide resolved
sabomichal
reviewed
Apr 24, 2023
|
|
||
| public SignRequestBody(Document document, ServerSigningParameters parameters, String payloadMimeType) { | ||
| this.document = document; | ||
| this.parameters = parameters; | ||
| this.payloadMimeType = payloadMimeType; | ||
| } | ||
|
|
||
| public InMemoryDocument getDocument() { | ||
| public InMemoryDocument getDocument() throws RequestValidationException { |
There was a problem hiding this comment.
nazvat tu metodu getDocument a nevracat interny dokument typu Document je nestandardne, nakolko kazdy pod tym chape property getter. Nazval by som tu metodu potom inak.
sabomichal
reviewed
Apr 24, 2023
src/main/java/digital/slovensko/autogram/server/dto/ServerSigningParameters.java
Show resolved
Hide resolved
Go 56/about dialog
Change LICENSE, refs GO-57
Go 86/todos cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toto je prvy nastrel cistej architektury + testov. Zatial su tam skratky a mozno pri napojeni na javafx este prideme na nejaku habaduru, ale zatial mam pocit, ze by to mohlo fungovat.