Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odkaz v emaili cez env vars #721

Closed
jsuchal opened this issue Mar 10, 2023 · 3 comments · Fixed by #762
Closed

Odkaz v emaili cez env vars #721

jsuchal opened this issue Mar 10, 2023 · 3 comments · Fixed by #762
Assignees
Labels
good first issue Good for newcomers

Comments

@jsuchal
Copy link
Member

jsuchal commented Mar 10, 2023

Momentalne musime synchronizovat sablony na sendinblue na prod/stage lebo odkazy na navodoch sa zvyknu mierne lisit medzi prostrediami aj rokmi. Po tom co @MarekVigas uz dal do env odkazy ktore idu na centralu kvoli tomu, aby vedela kam redirectnut po flowe ale treba toto dostat aj do emailu. Sablonu na sendinblue upravit vieme lahko, v kode vsak treba tento parameter posielat.

Netreba riesit teraz - tento release dobojujeme bez toho.

@jsuchal jsuchal added the good first issue Good for newcomers label Mar 10, 2023
@MarekVigas
Copy link
Collaborator

pozri #720

@jsuchal
Copy link
Member Author

jsuchal commented Mar 10, 2023

@MarekVigas ano viem, ale asi som to prilis z rychlika napisa. My mame ste aj sendinblue (to co posiela emaily) v dvoch prostrediach a su tam 2 typy sablon staging/prod lebo sa lisia len v linke na dalsi krok. Kedze uz tieto kroky nemame hardcoded (vid tvoj PR) tak este keby sme ich cez parameter dostali do sablony emailu, tak uz nemusime nic menit medzi stage/prod v sendinblue.

image

@jsuchal
Copy link
Member Author

jsuchal commented Mar 10, 2023

Doslova by malo stacit toto (ale plna url nie len path)

name: 'submission[callback_url]',

dat aj sem nejako

{
name: 'submission[extra][params][recipient_name]',
value: fullName,
},
{
name: 'submission[extra][params][deadline]',
value: deadline,
},

A pre danove to iste.

Vsetky tieto params sa posielaju do sendinblue ako parametre a su potom dostupne na naplnenie v sablone.

@tom-m tom-m self-assigned this Mar 24, 2023
@MarekVigas MarekVigas linked a pull request Mar 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants