Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example bottom_navigation_multiple_beamers not keeping state when changing tabs #183

Closed
getBoolean opened this issue Apr 11, 2021 · 7 comments
Labels
bug Something isn't working enhancement New feature or request P1 Priority 1; do before next release
Milestone

Comments

@getBoolean
Copy link

Hello, I tried to use this example, but I couldn't get it to work. I tried using both 0.11.2 and 1.0.0-pre.1.0. It seems that the state is not being saved.

Intended:
https://raw.githubusercontent.com/slovnicki/beamer_examples/master/bottom_navigation_multiple_beamers/example-bottom-navigation-multiple-beamers.gif

Actual:
MLXXJI4x9E

The repo I am working on is here, in case you want to check my setup

@slovnicki
Copy link
Owner

slovnicki commented Apr 11, 2021

Hi @getBoolean
Thanks for the feedback!

Yeah, this example was always kind of a work in progress and forgotten about most of the times during updates.

I'll see if I can fix it today.

EDIT: will check it today

@slovnicki
Copy link
Owner

This is a more fundamental problem that I thought. I'll try to resolve it this week.

@slovnicki slovnicki added bug Something isn't working enhancement New feature or request P1 Priority 1; do before next release working on This issue is currently being worked on labels Apr 13, 2021
@slovnicki slovnicki added this to the v1.0.0 milestone Apr 13, 2021
@slovnicki
Copy link
Owner

Quick update: I detected a major flaw - a cause of this behavior and a reason this example can never work as expected with current beamer.

It's the NavigationNotifier. Sibling Beamers are listening to eachother 🤦

So this will automatically be solved by #181, two birds with one stone.

@getBoolean
Copy link
Author

That's great to hear, thanks for the update.

@getBoolean
Copy link
Author

Also, would that be related to why when I change the theme with a provider (specifically hooks_riverpod), it goes back to the home page? repo
If it's not related, I can make another issue.
UEwwLgK88X

@slovnicki
Copy link
Owner

@getBoolean I believe this is a separate issue. Feel free to make a new issue and I will check your repo in the evening

@slovnicki slovnicki modified the milestones: v1.0.0, v0.12.0 Apr 18, 2021
slovnicki added a commit that referenced this issue Apr 18, 2021
	- [remove] the need for RootRouterDelegate by adding a parent-child relationship
	- [add] usage of state
	- [move] all beaming logic into update()
	- [tweaks]
	- closes #181 #183
@slovnicki slovnicki removed the working on This issue is currently being worked on label Apr 18, 2021
@slovnicki
Copy link
Owner

this should be fixed now. See example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request P1 Priority 1; do before next release
Projects
None yet
Development

No branches or pull requests

2 participants