Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support to opaque property in BeamPage #446

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Adds support to opaque property in BeamPage #446

merged 1 commit into from
Jan 6, 2022

Conversation

ggirotto
Copy link
Contributor

@ggirotto ggirotto commented Jan 6, 2022

Open to discussion

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #446 (d692cfb) into master (9ac04d9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   96.22%   96.24%   +0.02%     
==========================================
  Files          13       13              
  Lines         741      745       +4     
==========================================
+ Hits          713      717       +4     
  Misses         28       28              
Impacted Files Coverage Δ
package/lib/src/beam_page.dart 97.46% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac04d9...d692cfb. Read the comment docs.

Copy link
Owner

@slovnicki slovnicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice 👍
Thanks for the PR @ggirotto 💙

@slovnicki slovnicki merged commit 37e83be into slovnicki:master Jan 6, 2022
@ggirotto
Copy link
Contributor Author

ggirotto commented Jan 6, 2022

Thanks for the merge. We have a specific use-case that will benefit a lot from this property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants