Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates browser tab title setting method #657

Merged
merged 1 commit into from Feb 12, 2024

Conversation

lenzpaul
Copy link
Contributor

Refactoring with the primary goal of improving the code coverage metric. Previously the code coverage was 96.57% and now it is 97.1%. This change does not introduce new functionality nor change the existing behavior.

The changes are as follows:

  • Removed kIsWeb condition for calling the logic to set the title of the tab.
  • Introduced a new function setTabTitle. On web it calls on dart:html to set the title of the browser tab. On mobile, it is a no-op.

These changes allow the coverage tool to reach the code that sets the title of the tab on web.

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a675d2) 96.56% compared to head (a827d12) 97.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
+ Coverage   96.56%   97.11%   +0.55%     
==========================================
  Files          13       14       +1     
  Lines         903      902       -1     
==========================================
+ Hits          872      876       +4     
+ Misses         31       26       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@slovnicki slovnicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lenzpaul! 💙

@slovnicki slovnicki merged commit dcda31e into slovnicki:master Feb 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants