Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TCP accept AsyncRead + AsyncWrite #119

Closed
dragonnn opened this issue Jul 4, 2022 · 1 comment · Fixed by #164
Closed

Make TCP accept AsyncRead + AsyncWrite #119

dragonnn opened this issue Jul 4, 2022 · 1 comment · Fixed by #164

Comments

@dragonnn
Copy link

dragonnn commented Jul 4, 2022

Hi!
Would you accept a PR with reworks Modbus TCP to allow to use AsyncRead + AsyncWrite?
As a TcpStream has too AsyncRead + AsyncWrite so that shouldn't be hard to do.
Of course we could keep the current connect and connect_slave and just add connect_slave_from_transport or something like that.
My use case for that:

  • doing some connecting setup before starting working with tokio-modbus, I have connections where I first need to send a 'login' packet to have access to modbus
  • running modbus-tcp over udp, not a typical use case but I sometimes have to do that
@flosse flosse added the tcp label Oct 5, 2022
@uklotzde
Copy link
Member

uklotzde commented Mar 6, 2023

This is a prerequisite for #133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants