Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AsyncRead/AsyncWrite traits for generic TCP implementation #164

Merged
merged 3 commits into from Mar 9, 2023
Merged

Use AsyncRead/AsyncWrite traits for generic TCP implementation #164

merged 3 commits into from Mar 9, 2023

Conversation

uklotzde
Copy link
Member

@uklotzde uklotzde commented Mar 9, 2023

Going through the code revealed inconsistencies, bugs, and the unneeded use of async and Result.

@uklotzde uklotzde requested a review from flosse March 9, 2023 10:22
flosse
flosse approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@flosse flosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@flosse flosse merged commit 755d0ed into slowtec:main Mar 9, 2023
@uklotzde uklotzde deleted the tcp-async-stream branch March 12, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flosse flosse flosse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make TCP accept AsyncRead + AsyncWrite
2 participants
@uklotzde @flosse