Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please revise your code #7

Open
lusinlu opened this issue Apr 27, 2021 · 1 comment
Open

Please revise your code #7

lusinlu opened this issue Apr 27, 2021 · 1 comment

Comments

@lusinlu
Copy link

lusinlu commented Apr 27, 2021

Dear Authors,
with all respect to your work, based on my experiments I feel that eighter the presented text in the paper does not reflect the reality or the code that you have published contain bugs. For the purpose of empirical comparison with the other loss functions for my research I have tried to train Resnet50 on Cifar10, with the warm-up, without, with commenting log.sum(1), with clamping log(1 - pt)... in all cases, the loss is going to nan... Moreover, I can see in the issues that its not only for me, its common, no one can use the proposed loss and Im not even talking about improvements...
It is very frustrating to see that the research publish in such a high venue as ICCV is not only not reproducible but just simply not working (at least implementation provided by the authors).

@slryou41
Copy link
Owner

slryou41 commented May 3, 2021

Hi, this code was implemented based on the previous version of PyTorch. It seems like there is a numerical instability for the log computation, so I modified the code based on the internal implementation of binary cross entropy of PyTorch version 1.4.0. Sorry for the inconvenience. Also, if you train the model without cross entropy warm-up, you might have to optimize the learning rate decay scheduler. If you have the same problem with this updated code, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants