Add simple test for Maven builder #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKorcz
requested review from
asraa,
ianlewis,
laurentsimon and
joshuagl
as code owners
Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
AdamKorcz
force-pushed
the
maven-e2e-tests
branch
from
c6d3dca
to
fe95490
Compare
laurentsimon
reviewed
Aug 2, 2023
AdamKorcz
force-pushed
the
maven-e2e-tests
branch
from
e3fb7d5
to
458a9ff
Compare
Signed-off-by: AdamKorcz <adam@adalogics.com>
AdamKorcz
force-pushed
the
maven-e2e-tests
branch
from
458a9ff
to
d82c253
Compare
Signed-off-by: AdamKorcz <adam@adalogics.com>
add verification
|
@laurentsimon Could you have a look at the assertions I have added? |
ianlewis
reviewed
Aug 4, 2023
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
ianlewis
reviewed
Aug 4, 2023
Signed-off-by: AdamKorcz <adam@adalogics.com>
|
@laurentsimon @ianlewis Please have another look. |
laurentsimon
reviewed
Aug 9, 2023
There was a problem hiding this comment.
LGTM. Let's wait for final comment from @ianlewis , especially the one on bootstrap needs.
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
ianlewis
reviewed
Aug 9, 2023
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
.github/workflows/e2e.maven.workflow_dispatch.main.default.slsa3.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: AdamKorcz <adam@adalogics.com>
AdamKorcz
force-pushed
the
maven-e2e-tests
branch
from
373f8b1
to
2323009
Compare
Signed-off-by: AdamKorcz <adam@adalogics.com>
AdamKorcz
force-pushed
the
maven-e2e-tests
branch
from
2323009
to
69ff369
Compare
Signed-off-by: AdamKorcz <adam@adalogics.com>
laurentsimon
approved these changes
Aug 10, 2023
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
fix some linters Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
try fix other linter Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
|
@ianlewis take a final look. i think we're ready to merge |
|
Thanks @laurentsimon! |
|
I pushed some changes to your branch. Just fyi in case you want to edit the code, don't forget to pull |
ianlewis
reviewed
Aug 14, 2023
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
ianlewis
approved these changes
Aug 14, 2023
laurentsimon
added a commit
to slsa-framework/slsa-github-generator
that referenced
this pull request
Aug 15, 2023
Adds another `input` for the Maven builder to allow the user to specify the project directory. The current problem this solves is to make slsa-framework/example-package#253 work. This was suggested by @laurentsimon in slsa-framework/example-package#253 (comment) --------- Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com> Signed-off-by: AdamKorcz <adam@adalogics.com> Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com> Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple test for the Maven builder.
@laurentsimon