feat: gradle e2e at repo root #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ramonpetgrave64
requested review from
laurentsimon and
joshuagl
as code owners
mihaimaruseac
approved these changes
Feb 17, 2024
ianlewis
reviewed
Feb 19, 2024
.github/workflows/e2e.gradle.workflow_dispatch.main.project-at-repo-root.slsa3.yml
Show resolved
Hide resolved
.github/workflows/e2e.gradle.workflow_dispatch.main.project-at-repo-root.slsa3.yml
Show resolved
Hide resolved
|
seems to be working https://github.com/slsa-framework/example-package/actions/runs/7961521799. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds gradle e2e tests where the project root is also the repository root, to confirm the new fixes in
slsa-framework/slsa-github-generator#3250
The same gradle files at e2e/gradle/workflow_dispatch have been copied tot he repository root.
Testing
I could not get this new Action to work on my own fork. It , but I believe we would followup with a fix to the test or revert this PR if it fails.