Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: rename envs to dynenvs #30

Closed
Tracked by #75
laurentsimon opened this issue Apr 4, 2022 · 2 comments · Fixed by #84
Closed
Tracked by #75

Feature: rename envs to dynenvs #30

laurentsimon opened this issue Apr 4, 2022 · 2 comments · Fixed by #84

Comments

@laurentsimon
Copy link
Contributor

The builder takes an input envs to pass environment variables generated at build time (e.g., ldflags).
Static env variables are declared in the .slsa-goreleaser.yml file.

Shall we rename envs to dynenvs/dyn_envs/dynamic_envs?

@laurentsimon
Copy link
Contributor Author

@asraa @joshuagl any feedback on this one?

Context: env variables are defined in the config file by a user. But env variables that need to be dynamically resolved at compile time (LDFLAGS, e.g. to retrieve the Git version) need to use this input:

uses: slsa-framework/slsa-github-generator-go/.github/workflows/builder.yml@main
    with:
      # Optional: only needed if using ldflags.
      env: "VERSION_LDFLAGS:${{needs.args.outputs.ldflags}}"

I''m suggesting we use dynenv: "VERSION_LDFLAGS:${{needs.args.outputs.ldflags}}" or something to this effect instead.

Any preference on the name?

@joshuagl
Copy link
Member

joshuagl commented Apr 25, 2022

I like dynamic_env, generated_env or evaluated_env. My preference is that we indicate separate words (though I am open to camel case, rather than snake case) and that we use full words. I like "evaluated" and "generated" as "dynamic" may imply that it can change on each invocation of the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants