Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: official release #75

Closed
20 of 22 tasks
laurentsimon opened this issue Apr 6, 2022 · 4 comments
Closed
20 of 22 tasks

Feature: official release #75

laurentsimon opened this issue Apr 6, 2022 · 4 comments
Labels
area:go Issue related to the Go ecosystem
Milestone
GA for Go builder

Comments

@laurentsimon
Copy link
Collaborator

laurentsimon commented Apr 6, 2022 •
edited by ianlewis
Loading

This issue tracks what remains to be done for our first release:

To decide:

Nice to have:
@laurentsimon laurentsimon mentioned this issue Apr 7, 2022
Merged
joshuagl referenced this issue in joshuagl/slsa-github-generator-go Apr 25, 2022
@joshuagl
feat: read arch from environment
35295de 
Read the runner's arch from the RUNNER_ARCH environment variable, rather
than hard-coding the current default.

Fixes #38

Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl referenced this issue in joshuagl/slsa-github-generator-go Apr 25, 2022
@joshuagl
feat: read arch from environment
0bb677c 
Read the runner's arch from the RUNNER_ARCH environment variable, rather
than hard-coding the current default.

Fixes #38

Signed-off-by: Joshua Lock <jlock@vmware.com>
@laurentsimon laurentsimon reopened this Apr 28, 2022
@laurentsimon laurentsimon transferred this issue from slsa-framework/slsa-github-generator-go May 20, 2022
@laurentsimon laurentsimon added the area:go Issue related to the Go ecosystem label May 20, 2022
@laurentsimon laurentsimon added this to the v1 milestone May 20, 2022
@ianlewis
Copy link
Member

If we can, we should try to add using the following ldflags to go build commands for releases.
-ldflags="-X github.com/slsa-framework/slsa-github-generator/version.Version=X.Y"

https://github.com/slsa-framework/slsa-github-generator/blob/main/version/version.go

@laurentsimon
Copy link
Collaborator Author

Should be do-able using ${{github.ref_name}}

@ianlewis
Copy link
Member

I added #410 for the version comment above.

Can we close this issue and close out the Go builder GA milestone? https://github.com/slsa-framework/slsa-github-generator/milestone/1

@laurentsimon
Copy link
Collaborator Author

SGTM, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:go Issue related to the Go ecosystem
Projects
None yet
Milestone
GA for Go builder
Development

No branches or pull requests
2 participants
@ianlewis @laurentsimon