Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use new APIs #37

Closed
Tracked by #75
laurentsimon opened this issue Apr 6, 2022 · 3 comments · Fixed by #57
Closed
Tracked by #75

Feature: Use new APIs #37

laurentsimon opened this issue Apr 6, 2022 · 3 comments · Fixed by #57
Assignees

Comments

@laurentsimon
Copy link
Contributor

Move to the new APIs defined in https://github.com/slsa-framework/slsa-github-generator

@laurentsimon
Copy link
Contributor Author

laurentsimon commented Apr 12, 2022

@ianlewis when do you think we should attempt a "migration" to the new API? What are the main blockers we should address before attempting it? (I think we want to do the migration before the first v1 release on this repo; but let us know if you think that's a bad idea)

I am a worried the 2 implementation may start drifting away or duplicate effort, e.g., #16 is a tracking issue in both repos.

@ianlewis
Copy link
Member

Yeah, I think we can start now but we will want to solidify the API of both and release both together for v1. We just need to keep in mind that some (hopefully small) changes to the API may happen in the meantime.

@ianlewis
Copy link
Member

On, the flip side, if there is missing functionality in the slsa-github-generator API that we need, please make sure we have an issue for it in that repo. I think we've covered most things already but just a reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants