Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository_id and actor_id to provenance #140

Closed
Tracked by #75
laurentsimon opened this issue May 31, 2022 · 2 comments · Fixed by #142
Closed
Tracked by #75

Add repository_id and actor_id to provenance #140

laurentsimon opened this issue May 31, 2022 · 2 comments · Fixed by #142
Assignees
Labels
type:feature New feature or request

Comments

@laurentsimon
Copy link
Collaborator

There's a recent attack that manages to re-name repositories https://sockpuppets.medium.com/how-i-hacked-ctx-and-phpass-modules-656638c6ec5e, which would bypass the current provenance verification.

We can protect agains this by recording the repository_id, see https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#understanding-the-oidc-token

This could also be added to Fulcio's certificate generation. @asraa shall we start a threat about this on sigstore repos?

For the time being, let's record it as part of the invocation, and provide some examples in the README how to extract it, e.g. via ja

@laurentsimon laurentsimon self-assigned this May 31, 2022
@laurentsimon laurentsimon added this to the v1 milestone May 31, 2022
@laurentsimon laurentsimon added the type:feature New feature or request label May 31, 2022
@laurentsimon
Copy link
Collaborator Author

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2419171690
Workflow name: go schedule main SLSA3 config-noldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/
Trigger: schedule
Branch: main
Date: Wed Jun 1 04:02:50 UTC 2022

@laurentsimon
Copy link
Collaborator Author

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2420591002
Workflow name: go schedule main SLSA3 adversarial build provenance
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/
Trigger: schedule
Branch: main
Date: Wed Jun 1 09:30:17 UTC 2022

Tests are passing now. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant