Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Support a configurable Rekor URL #372

Closed
3 tasks
asraa opened this issue Jun 21, 2022 · 5 comments · Fixed by #391
Closed
3 tasks

[feature] Support a configurable Rekor URL #372

asraa opened this issue Jun 21, 2022 · 5 comments · Fixed by #391
Labels
area:container Issue with the generic container generator area:generic Issue with the generic generator area:go Issue related to the Go ecosystem area:tests An issue with tests (unit, e2e, etc.) status:duplicate This issue or pull request already exists type:feature New feature or request

Comments

@asraa
Copy link
Collaborator

asraa commented Jun 21, 2022 •
edited by ianlewis
Loading

Is your feature request related to a problem? Please describe.
This will allow for people to configure a rekor URL for upload, which will mean we can configure verifier e2e tests to use rekor staging and avoid rate limiting.

Describe the solution you'd like
This should be defined as an input

  • Go workflow
  • Generic workflow
  • Container workflow
@asraa asraa added type:feature New feature or request status:triage Issue that has not been triaged labels Jun 21, 2022
@ianlewis
Copy link
Member

This came up in #34 previously.

@ianlewis ianlewis mentioned this issue Jun 22, 2022
Open
@ianlewis ianlewis added area:generic Issue with the generic generator go Pull requests that update Go code area:go Issue related to the Go ecosystem area:tests An issue with tests (unit, e2e, etc.) and removed status:triage Issue that has not been triaged go Pull requests that update Go code labels Jun 22, 2022
@ianlewis ianlewis mentioned this issue Jun 24, 2022
Open
@ianlewis
Copy link
Member

Created #387 to cover updating the e2e tests

naveensrinivasan added a commit to naveensrinivasan/slsa-github-generator that referenced this issue Jun 24, 2022
@naveensrinivasan
Option to configure rekor server.
5825482 
- Provided an option to configure the rekor server.
- Fixes slsa-framework#372

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan naveensrinivasan mentioned this issue Jun 24, 2022
Merged
naveensrinivasan added a commit to naveensrinivasan/slsa-github-generator that referenced this issue Jun 24, 2022
@naveensrinivasan
Option to configure rekor server.
c5cc9ed 
- Provided an option to configure the rekor server.
- Fixes slsa-framework#372

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
naveensrinivasan added a commit to naveensrinivasan/slsa-github-generator that referenced this issue Jun 24, 2022
@naveensrinivasan
Option to configure rekor server.
edde538 
- Provided an option to configure the rekor server.
- Fixes slsa-framework#372

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
laurentsimon added a commit that referenced this issue Jun 27, 2022
@naveensrinivasan @laurentsimon
Option to configure rekor server. (#391)
c206bf3 
* Option to configure rekor server.

- Provided an option to configure the rekor server.
- Fixes #372

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

* mend

Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
@ianlewis
Copy link
Member

Reopen to support in generic workflow

@ianlewis ianlewis reopened this Jun 28, 2022
@ianlewis ianlewis self-assigned this Jun 28, 2022
@ianlewis ianlewis added the area:container Issue with the generic container generator label Jun 28, 2022
@asraa asraa mentioned this issue Jun 29, 2022
Closed
laurentsimon added a commit to laurentsimon/slsa-github-generator that referenced this issue Jun 29, 2022
@naveensrinivasan @laurentsimon
Option to configure rekor server. (slsa-framework#391)
21ede71 
* Option to configure rekor server.

- Provided an option to configure the rekor server.
- Fixes slsa-framework#372

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

* mend

Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
@asraa asraa mentioned this issue Oct 13, 2022
Closed
@asraa asraa added this to the 2022 Stability improvements milestone Oct 27, 2022
@ianlewis
Copy link
Member

#391 Adds an option to configure the Rekor server address internally but we still need to support inputs to the workflows and a way to configure the TUF trust roots.

@ianlewis ianlewis removed their assignment Nov 18, 2022
@s-spindler s-spindler mentioned this issue Dec 30, 2022
Open
@ianlewis ianlewis removed this from the 2022 Stability improvements milestone Jan 12, 2023
@ianlewis
Copy link
Member

This issue is subsumed by #3607 which will cover all sigstore servers including Fulcio

@ianlewis ianlewis closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
@ianlewis ianlewis added the status:duplicate This issue or pull request already exists label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:container Issue with the generic container generator area:generic Issue with the generic generator area:go Issue related to the Go ecosystem area:tests An issue with tests (unit, e2e, etc.) status:duplicate This issue or pull request already exists type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Option to configure rekor server. naveensrinivasan/slsa-github-generator
2 participants
@ianlewis @asraa