Action Required: Fix Renovate Configuration #404
Comments
|
/cc @naveensrinivasan Maybe we could start with the default config to see if it works, and in a few days add more options? |
This was referenced May 14, 2024
5 tasks
ramonpetgrave64
pushed a commit
that referenced
this issue
May 15, 2024
# Summary Change Renovate schedule to cron syntax. Fixes #404 ## Testing Process Code inspection only ## Checklist - [x] Review the contributing [guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md) - [x] Add a reference to related issues in the PR description. - [x] Update documentation if applicable. - [x] Add unit tests if applicable. - [x] Add changes to the [CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) if applicable. Signed-off-by: Rhys Arkins <rhys@arkins.net>
ramonpetgrave64
added a commit
that referenced
this issue
May 15, 2024
# Summary Fixes renovate config to use the [`config:best-practices`](https://docs.renovatebot.com/presets-config/#configbest-practices) preset rather than the `config:base` preset since `config:base` seems to have gone away at some point. Also fixes the `schedule` config by using the [`schedule:monthly`](https://docs.renovatebot.com/presets-schedule/#schedulemonthly) preset. The previous `schedule` config seems to have been invalid because "4 am" had space between "4" and "am" (this was fixed in the `slsa-verifier` repo on slsa-framework/slsa-verifier#727 but was never fixed here). Also adds a pre-submit to run the [`renovate-config-validator`](https://docs.renovatebot.com/config-validation/) to ensure that renovate config is valid. This pre-submit will need to be made required in the repository branch protection rule for `main` in the repository settings after this PR is merged. Fixes #3634 #404 ## Testing Process - Run `make renovate-config-validator` to check that the config is valid. ## Checklist - [x] Review the contributing [guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md) - [x] Add a reference to related issues in the PR description. - [x] Update documentation if applicable. - [x] Add unit tests if applicable. - [x] Add changes to the [CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) if applicable. --------- Signed-off-by: Ian Lewis <ianlewis@google.com> Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com> Co-authored-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
This was referenced May 16, 2024
ramonpetgrave64
pushed a commit
that referenced
this issue
May 17, 2024
# Summary - Set `configWarningReuseIssue` to `false`. Old behavior: Renovate re-opens a old config warning issue. New behavior: Renovate creates a new config warning issue. Read the [Renovate docs, `configWarningReuseIssue` config option](https://docs.renovatebot.com/configuration-options/#configwarningreuseissue) to learn more. ## More context @ianlewis mentioned they want Renovate to create a _new issue_ instead of _re-opening_ an old one: - #3635 (comment) Here's an example of a Renovate config warning issue that was re-opened by Renovate recently: - #404 ## Testing Process - Manually reviewed configuration change ## Checklist - [x] Review the contributing [guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md) - [x] Add a reference to related issues in the PR description. - [ ] Update documentation if applicable. - [ ] Add unit tests if applicable. - [ ] Add changes to the [CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) if applicable. Signed-off-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.
Location:
renovate.jsonError type: The renovate configuration file contains some invalid settings
Message: Invalid schedule:
Invalid schedule: Failed to parse "before 4 am on the first day of the month"The text was updated successfully, but these errors were encountered: