Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use GITHUB_OUTPUT instead of deprecated set-output command #1066

Merged
merged 3 commits into from
Oct 21, 2022
Merged

fix: use GITHUB_OUTPUT instead of deprecated set-output command #1066

merged 3 commits into from
Oct 21, 2022

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Oct 17, 2022 •
edited
Loading

@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review October 17, 2022 08:29
@ianlewis
Copy link
Member

I merged #1061 but we should probably wait to merge this until v1.2.1 is released.

@ianlewis
Copy link
Member

@suzuki-shunsuke I think we can merge this but there is a conflict in one of the files and I can't fix it myself. Can you fix it? then we can merge.

@suzuki-shunsuke
Copy link
Contributor Author

suzuki-shunsuke commented Oct 21, 2022 •
edited
Loading

Sure. I'm fixing.
The action .github/actions/secure-checkout seems to be removed in the main branch.

@ianlewis
Copy link
Member

Sure. I'm fixing. The action .github/actions/secure-checkout seems to be removed in the main branch.

Yeah, you can probably just ignore the changes there.

@ianlewis ianlewis enabled auto-merge (squash) October 21, 2022 02:29
@ianlewis ianlewis merged commit a357a77 into slsa-framework:main Oct 21, 2022
@suzuki-shunsuke suzuki-shunsuke deleted the fix/use-github_output-2 branch October 21, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@asraa asraa Awaiting requested review from asraa

@ianlewis ianlewis Awaiting requested review from ianlewis

@joshuagl joshuagl Awaiting requested review from joshuagl joshuagl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suzuki-shunsuke @ianlewis @laurentsimon