Skip to content

fix: use GITHUB_OUTPUT instead of deprecated set-output command - #1066

Merged
ianlewis merged 3 commits into
slsa-framework:mainfrom
suzuki-shunsuke:fix/use-github_output-2
Oct 21, 2022
Merged

fix: use GITHUB_OUTPUT instead of deprecated set-output command#1066
ianlewis merged 3 commits into
slsa-framework:mainfrom
suzuki-shunsuke:fix/use-github_output-2

Conversation

@suzuki-shunsuke

@suzuki-shunsuke suzuki-shunsuke commented Oct 17, 2022

Copy link
Copy Markdown
Contributor

@suzuki-shunsuke
suzuki-shunsuke marked this pull request as ready for review October 17, 2022 08:29
@ianlewis

Copy link
Copy Markdown
Member

I merged #1061 but we should probably wait to merge this until v1.2.1 is released.

@ianlewis

Copy link
Copy Markdown
Member

@suzuki-shunsuke I think we can merge this but there is a conflict in one of the files and I can't fix it myself. Can you fix it? then we can merge.

@suzuki-shunsuke

suzuki-shunsuke commented Oct 21, 2022

Copy link
Copy Markdown
Contributor Author

Sure. I'm fixing.
The action .github/actions/secure-checkout seems to be removed in the main branch.

@ianlewis

Copy link
Copy Markdown
Member

Sure. I'm fixing. The action .github/actions/secure-checkout seems to be removed in the main branch.

Yeah, you can probably just ignore the changes there.

@ianlewis
ianlewis enabled auto-merge (squash) October 21, 2022 02:29
@ianlewis
ianlewis merged commit a357a77 into slsa-framework:main Oct 21, 2022
@suzuki-shunsuke
suzuki-shunsuke deleted the fix/use-github_output-2 branch October 21, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants