Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkout uses the wrong repository #1113

Merged
merged 5 commits into from
Oct 21, 2022

Conversation

laurentsimon
Copy link
Collaborator

@laurentsimon laurentsimon commented Oct 21, 2022

This will fix the current error that affects all e2e tests.
The PR also uses @main for all the actions we use. We will set these to the tag release before release. I have added pre-release workflows to verify the release tag and the reference of the Actions is the same' and amended the RELEASE.md accordingly.

Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you quickly explain the end-state?
these actions would eventually be checked out at a resulting ref from detect-env?

@laurentsimon
Copy link
Collaborator Author

could you quickly explain the end-state? these actions would eventually be checked out at a resulting ref from detect-env?

correct. During development, we always reference them at @main. This ensure we're using the most recent code.

At release time, the "entry Actions" are pinned by version. Example: someone calls our generator at @v1.2.3. The entry Actions will be referenced with the same @v1.2.3. This ensure the code that is run is the code from a particular tag, not a combination of different hashes.

The pre-release verifies that.

Let me know if you have questions.

@laurentsimon laurentsimon merged commit ce2408f into slsa-framework:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants