Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang digest to 9349ed8 #557

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jul 16, 2022

Mend Renovate

This PR contains the following updates:

Package Type Update Change
golang stage digest a452d62 -> 9349ed8

Configuration

πŸ“… Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Collaborator

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the Dockerfile to a version different from the GitHub action that tests run could have discrepancies.

To be consistent, both GitHub actions and the Docker build must have the same Go version.

In this PR it will upgrade the Docker container but the Action that runs the tests aren't upgraded.

@laurentsimon
Copy link
Collaborator

we need to update the container first and then updates the calls to ./actions/detect-workflow. It's described in https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/actions/README.md

Renovatebot will ask us to bump the detect-workflow hash this week end.

@naveensrinivasan is there something specific you wanted to address in this PR?

@naveensrinivasan
Copy link
Collaborator

we need to update the container first and then updates the calls to ./actions/detect-workflow. It's described in https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/actions/README.md

Renovatebot will ask us to bump the detect-workflow hash this week end.

@naveensrinivasan is there something specific you wanted to address in this PR?

πŸ‘

@ianlewis
Copy link
Member

@rarkins BTW, is it possible for the renovate bot to maintain # tag=x.x comments in Dockerfiles too? Maybe with a comment on the proceding line of a FROM?

@ianlewis
Copy link
Member

Also, just a reminder that we should make sure to check the digest is documented here before merging. See #592

I verified that this is the sha for 1.18.4

@ianlewis ianlewis enabled auto-merge (squash) July 27, 2022 01:25
@ianlewis ianlewis merged commit 8afd805 into slsa-framework:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants