✨ Pull builder's binary instead of compiling it #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
commented
May 24, 2022
| # Verifier | ||
| VERIFIER_REPOSITORY: slsa-framework/slsa-verifier | ||
| VERIFIER_RELEASE_BINARY: slsa-verifier-linux-amd64 | ||
| VERIFIER_RELEASE_BINARY_SHA256: fb743bc6bb56908d590da66bfe5c266d003aa226b30fcada5f7b9e4aea43b52b |
There was a problem hiding this comment.
Note: this hash is invalid. We will update it once we (the maintainers) have cut a release for the verifier and verified the hash is valid thru provenance - see #74 (comment)
laurentsimon
commented
May 24, 2022
| @@ -202,7 +218,6 @@ jobs: | |||
| - name: Verify builder | |||
| env: | |||
| BUILDER_HASH: "${{ needs.builder.outputs.go-builder-sha256 }}" | |||
| BUILDER_BINARY: "${{ env.BUILDER_BINARY }}" | |||
There was a problem hiding this comment.
Note: I've removed all occurrences of BUILDER_BINARY: "${{ env.BUILDER_BINARY }}" because they are not needed
laurentsimon
commented
May 24, 2022
|
|
||
| set -euo pipefail | ||
|
|
||
| # Caller sets the following: |
There was a problem hiding this comment.
Note: We will replace this script with Golang code in the future #87
Closed
asraa
reviewed
May 25, 2022
| required: false | ||
| type: string | ||
| compile-builder: | ||
| description: "Build the builder from source. This speeds up build time by ~2mn." |
There was a problem hiding this comment.
This increases the build time?
There was a problem hiding this comment.
no it does not ^^. Thanks for catching this
asraa
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #74 and speeds up the time it takes to build.