feat: make branch optional #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
force-pushed
the
feat/commpitreal
branch
from
98216fa
to
8b09549
Compare
This was referenced Aug 8, 2022
ianlewis
approved these changes
Aug 9, 2022
laurentsimon
force-pushed
the
feat/commpitreal
branch
from
cb05411
to
39e3b4f
Compare
asraa
approved these changes
Aug 9, 2022
laurentsimon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a release is made from a commit (rather than a branch):
./slsa-verifier-linux-amd64 \ -provenance artifacts.intoto.jsonl \ -artifact-path secure_package_template-0.2.0-py3-none-any.whl \ -tag 0.1.9 \ -source github.com/sethmlarson/python-slsa-release-test FAILED: SLSA verification failed: invalid DSSE envelope payload: environment type stringThis PR changes the behavior to:
This PR also makes the branch an optional argument to the CLI.
We need to add support for commit, see #180 (comment)