Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: env vars are case sensitive in configuration #298

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Oct 8, 2022

Signed-off-by: Asra Ali asraa@google.com

Tested with the build-dry command, before and after.

asraa@asraa1:~/git/slsa-verifier$  ~/Downloads/slsa-builder-go-linux-amd64  build --dry .github/config-release.yml VERSION:
&{linux amd64 <nil> 0xc0005880f0 map[CGO_ENABLED:0 GO111MODULE:on] [-trimpath -tags=netgo] [-X sigs.k8s.io/release-utils/version.gitVersion={{ .Env.Version }}] slsa-verifier-{{ .Os }}-{{ .Arch }}}
&{linux amd64 <nil> 0xc000155700 map[CGO_ENABLED:0 GO111MODULE:on] [-trimpath -tags=netgo] [-X sigs.k8s.io/release-utils/version.gitVersion={{ .Env.Version }}] slsa-verifier-{{ .Os }}-{{ .Arch }}}
arg env: VERSION:
env variable empty or not set: {{ .Env.Version }}bash: syntax error near unexpected token `&'
asraa@asraa1:~/git/slsa-verifier$ ~/Downloads/slsa-builder-go-linux-amd64 build --dry .github/config-release.yml VERSION:
&{linux amd64 <nil> 0xc0005880f0 map[CGO_ENABLED:0 GO111MODULE:on] [-trimpath -tags=netgo] [-X sigs.k8s.io/release-utils/version.gitVersion={{ .Env.VERSION }}] slsa-verifier-{{ .Os }}-{{ .Arch }}}
&{linux amd64 <nil> 0xc000596740 map[CGO_ENABLED:0 GO111MODULE:on] [-trimpath -tags=netgo] [-X sigs.k8s.io/release-utils/version.gitVersion={{ .Env.VERSION }}] slsa-verifier-{{ .Os }}-{{ .Arch }}}
arg env: VERSION:
::set-output name=go-binary-name::slsa-verifier-linux-amd64
::set-output name=go-command::WyIvdXNyL2xvY2FsL2dvL2Jpbi9nbyIsImJ1aWxkIiwiLW1vZD12ZW5kb3IiLCItdHJpbXBhdGgiLCItdGFncz1uZXRnbyIsIi1sZGZsYWdzPS1YIHNpZ3MuazhzLmlvL3JlbGVhc2UtdXRpbHMvdmVyc2lvbi5naXRWZXJzaW9uPSIsIi1vIiwic2xzYS12ZXJpZmllci1saW51eC1hbWQ2NCJd
::set-output name=go-env::WyJHT09TPWxpbnV4IiwiR09BUkNIPWFtZDY0IiwiR08xMTFNT0RVTEU9b24iLCJDR09fRU5BQkxFRD0wIl0=
::set-output name=go-working-dir::/home/asraa/git/slsa-verifier/cli/slsa-verifier

Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa merged commit e6428d7 into slsa-framework:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants