-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style: Wrapping at sentences instead of lines #75
Comments
Sure, seems fine, just need to do at a time when there are no other active edits. |
I've been using |
Is there an OSS equivalent we could point contributors to? |
there is https://mdformat.readthedocs.io/en/stable/ , might be better or worse, not sure. we can try running on current spec and see if major diff. |
That one doesn't handle line-wrapping explicitly, for similar reasons to the one I outlined: https://mdformat.readthedocs.io/en/stable/ |
AIUI the desire is to present industry consensus, so a big +1 to using open tools |
Sounds good. I'll take a look at one of the open-source mdformat to see if it works, but if not, we can just go with the OCI style guide. |
I found the open-source mdformat needlessly opinionated, so I set up markdownlint in #83. The only main change is consistent use of bullet character. It doesn't address line length, but I have no objections to wrapping at sentences. Would we still wrap at 80 columns AND sentences, or just have really long lines? |
MD013 is the rule for line length. |
Thanks, @06kellyjac. By "address line length," I meant that neither mdlint nor mdformat will fulfill @dlorenc's original request to switch to semantic line breaks. Doing so must be done manually and requires some sort of human-readable guidelines rather than tooling. Personally I find long lines hard to work with and manual wrapping to be more toil than just running I'm happy to go with whatever the consensus is. Just let me know. By the way, aaf3cc7 is the result of open-source mdformat in case you're interested. |
Agreed. I personally prefer a column limit too and find long lines hard work.
My main vote would be for something tooling can enforce. |
I think the work that remains is to write some little blurb about the style guidelines. |
Fixed by 3282d70. |
This is definitely a preference thing, but I find markdown easier to work with and diff when we wrap at sentences instead of characters. See the OCI style guide for an example: https://github.com/opencontainers/image-spec#markdown-style
Any opposition to switching to this from the current 80 char convention?
The text was updated successfully, but these errors were encountered: