Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: slsa generator and verifier v1 release #398

Merged
merged 14 commits into from
Jun 21, 2022
Merged

blog: slsa generator and verifier v1 release #398

merged 14 commits into from
Jun 21, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Jun 13, 2022

Signed-off-by: Asra Ali asraa@google.com

Adds a blog post (scheduled for 6/20) on the v1 release of the SLSA GitHub generator workflows and verifier CLI.

cc @laurentsimon @ianlewis @MarkLodato @joshuagl @josepalafox

@netlify
Copy link

netlify bot commented Jun 13, 2022 •
edited
Loading

✅ Deploy Preview for slsa ready!

Name Link
🔨 Latest commit c954cc8
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/62b1f039fd11ee000974a5a0
😎 Deploy Preview https://deploy-preview-398--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@inferno-chromium inferno-chromium requested a review from a team June 13, 2022 18:42
laurentsimon
laurentsimon reviewed Jun 13, 2022
View reviewed changes
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
laurentsimon
laurentsimon approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ianlewis
ianlewis approved these changes Jun 13, 2022
View reviewed changes
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
joshuagl
joshuagl approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
@inferno-chromium
Copy link
Contributor

This is ready to be rebased (since another blog post was merged), also please incorporate @joshuagl suggestions. Then we can ask the slsa committee for review.

@asraa
Copy link
Contributor Author

asraa commented Jun 15, 2022

Addressed, rebased and fixed lint!

@inferno-chromium inferno-chromium requested a review from a team June 16, 2022 03:32
@dlorenc
Copy link

dlorenc commented Jun 16, 2022

Nice post!

MarkLodato
MarkLodato reviewed Jun 16, 2022
View reviewed changes
docs/_posts/2022-06-20-slsa-workflows.md Outdated
@@ -0,0 +1,157 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this is not showing up at https://deploy-preview-398--slsa.netlify.app/blog, even though it did build from cca3877.

Could you try building locally to see if it shows up there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inferno-chromium @asraa this seems to be the last blocker. Anyone familiar with netlify?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am guessing this is because of the future date, try with today's date and i think it will work.

docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
docs/_posts/2022-06-20-slsa-workflows.md Outdated Show resolved Hide resolved
@laurentsimon laurentsimon mentioned this pull request Jun 16, 2022
Merged
23 tasks
@inferno-chromium inferno-chromium mentioned this pull request Jun 16, 2022
Closed
@laurentsimon laurentsimon mentioned this pull request Jun 17, 2022
Closed
asraa and others added 9 commits June 20, 2022 09:50
@asraa
blog post: slsa generator and verifier v1 release
d2d9cad 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
update
c620043 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
make updates
e1c0de0 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
fix lint
166ac20 
Signed-off-by: Asra Ali <asraa@google.com>
@laurentsimon @asraa
Rename 2022-06-20-slsa-workflows.md to 2022-06-20-slsa-github-workflo…
7a6cd1d 
…ws.md

Signed-off-by: Asra Ali <asraa@google.com>
@laurentsimon @asraa
Remove v0.2 from provenance URL
fd3269e 
Signed-off-by: Asra Ali <asraa@google.com>
@laurentsimon @asraa
Update 2022-06-20-slsa-github-workflows.md
09808ca 
Signed-off-by: Asra Ali <asraa@google.com>
@laurentsimon @asraa
Change Golang to Go
d005595 
Signed-off-by: Asra Ali <asraa@google.com>
@laurentsimon @asraa
Update 2022-06-20-slsa-github-workflows.md
a355789 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
Add info on availability of starter workflow this week
c5a8b20 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
Copy link
Contributor Author

asraa commented Jun 20, 2022 •
edited
Loading

Fixed DCO, and looks like the preview is live, it seems like it was the date issue
https://deploy-preview-398--slsa.netlify.app/blog

EDIT: It looks like the coloring on shell code comments turns up bad -- the words are too close to the background color. Any advice on the best way to change that? Color theme in the config yaml? I don't want to change the theme D:

@asraa
update version info
77561f1 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
add image
9564448 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
update the starter workflow
ffd27e8 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
Copy link
Contributor Author

asraa commented Jun 21, 2022

This is ready for merge!
cc @laurentsimon @inferno-chromium

@inferno-chromium inferno-chromium merged commit 5941f28 into slsa-framework:main Jun 21, 2022
@inferno-chromium
Copy link
Contributor

Merged based on Joshua's LGTM and comments from Mark, Mike addressed. In future, we will make sure LGTMs are got from atleast one more reviewer. There is a talk from Asra, Laurent today, so this needs to be merged to reference that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLodato MarkLodato MarkLodato left review comments

@mlieberman85 mlieberman85 mlieberman85 left review comments

@inferno-chromium inferno-chromium inferno-chromium left review comments

@joshuagl joshuagl joshuagl approved these changes

@chipzoller chipzoller chipzoller left review comments

@laurentsimon laurentsimon laurentsimon approved these changes

@pxp928 pxp928 pxp928 left review comments

@ianlewis ianlewis ianlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@asraa @inferno-chromium @dlorenc @ianlewis @MarkLodato @mlieberman85 @joshuagl @chipzoller @laurentsimon @pxp928