Identify privileged users #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the automated tracking of users, along with their status and statistics. Users that have been explicitly added to a group in configuration are watched on connect. Other users are transiently watched when they enqueue an upload.
A lot of the work here was necessary to enable the application to track whether users are privileged; unfortunately it involved a lot of thread-pulling to achieve this. This does pave the way for a fairly easy implementation of the anti-leech detection needed for #361.
Users that have been identified as being privileged by the server will now be automatically assigned to the
privilegedinternal group, allowing them to be prioritized over all other users when processing the queue and determining upload speed.Closes #362