Update existing shared file database instead of creating a new one for each scan #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…currently with filesystem changes.
This was referenced Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently the database is wiped at the beginning of the scan, and then repopulated. While the scan is running things like share browsing, file downloads, and search responses are unavailable.
This PR ends the behavior of wiping the database, and instead replaces records as files are scanned, allowing the application to continue working normally.
A new
timestampfield is added to the file and directory tables in the database, and this field is populated with the timestamp of the start of the scan. When the scan is complete, any records that have a timestamp older than the timestamp of the recently completed scan are deleted, as these files weren't encountered during the new scan, meaning they have been deleted, moved, or unshared.