Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to cancel a share scan #656

Merged
merged 22 commits into from
Sep 25, 2022
Merged

Add the ability to cancel a share scan #656

merged 22 commits into from
Sep 25, 2022

Conversation

jpdillingham
Copy link
Member

@jpdillingham jpdillingham commented Sep 24, 2022

I decided to tackle a bunch of stuff all at once:

  • Adds an application-level cancellation token to help things shut down in a timely manner, especially when a scan is in progress
  • Adds the ability to cancel share scans, along with an API endpoint and button on the UI
  • Fixes a number of issues with share counts and state (reverses a bug that was added recently)
  • Vastly improves the performance of the display of share configuration
  • Forces a share scan if the application can't load the shared file cache on start (this also fixes the issue with share counts/status being unknown, as shares are either loaded, or scanned at startup)
  • Updates the UI every 1% of scan progress, instead of 5% (this is all the monitoring I want to provide at the moment)

Closes #490
Closes #443
Closes #532

@jpdillingham jpdillingham merged commit cabbd9c into master Sep 25, 2022
@jpdillingham jpdillingham deleted the cancel-scan branch September 25, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant