Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect change in share configuration, 'dirty' scan, or any other reason shares are in a known bad or questionable state at startup and force scan if needed #760

Merged
merged 6 commits into from Nov 20, 2022
Merged

Detect change in share configuration, 'dirty' scan, or any other reason shares are in a known bad or questionable state at startup and force scan if needed #760

merged 6 commits into from Nov 20, 2022

Conversation

jpdillingham
Copy link
Member

@jpdillingham jpdillingham commented Nov 18, 2022 •
edited

This PR helps ensure that the application always starts with a valid share cache.

Forces a scan:

  • If no scan records exist at startup
  • If the most recent scan record has been marked as suspect
  • If the most recent scan record has a null end timestamp
  • If options changed offline (already tested, but might as well test again)
  • Doesn't force a scan if none of the above is true

Closes #658

@jpdillingham jpdillingham merged commit 0651921 into master Nov 20, 2022
@jpdillingham jpdillingham deleted the config-scan branch November 20, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jpdillingham