Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple fixes #56

Merged
merged 6 commits into from
Dec 20, 2021
Merged

Simple fixes #56

merged 6 commits into from
Dec 20, 2021

Conversation

bertsky
Copy link
Member

@bertsky bertsky commented Dec 3, 2021

Fixes #52 #51 #46

@bertsky
Copy link
Member Author

bertsky commented Dec 3, 2021

Note: I have tested these, but not added new tests.

@bertsky
Copy link
Member Author

bertsky commented Dec 3, 2021

(Removed the GH actions badge again – sry for the noise.)

@bertsky bertsky requested a review from wrznr December 3, 2021 17:32
@bertsky
Copy link
Member Author

bertsky commented Dec 3, 2021

CI: I don't know how we can test this outside of master. But since it depends on the recent Makefile changes, I added it here.

Copy link
Collaborator

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is superseeded by #58, right?

@bertsky
Copy link
Member Author

bertsky commented Dec 7, 2021

This is superseeded by #58, right?

Yes, it says it right there: Expands on #56, additionally fixes #57.

The idea was for @wrznr to be able to merge the smaller changeset first (but he fell ill and I had to keep going).

.circleci/config.yml Show resolved Hide resolved
@wrznr
Copy link
Member

wrznr commented Dec 20, 2021

Shall we still merge?

@bertsky
Copy link
Member Author

bertsky commented Dec 20, 2021

Shall we still merge?

It will make #58 a little smaller, but still too large to view at once I'm afraid.

As you please.

@wrznr wrznr merged commit 426ad91 into slub:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants