RFC based rewrite #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly v6 -> use v6, removal of debug code, simplification of pair literals, redundant newlines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1)Test data is replaced with examples directly from RFC to not re-invent a wheel.
2)The grammar was rewritten mostly with direct translation from ABNF of RFC into Perl 6 grammar rules.
3)Patched actions class to make up with new parsing tree.
4)README is updated to reflect changes.
5)Version is bumped to 1.0, as we now support all examples from RFC, please, note if something important is missing.
6)I did not introduce a new object, as there might be many modules related to LDAP in future and it'll be a bad practice to make it too specific, so continue with builtin Perl 6 types structure.
7)Some debug lines were removed.