segwit support #16
segwit support #16
Conversation
This has been removed for a while.
Rather than trying to de-serialize and re-serialize the transactions coming from GBT, simply store them as binary and use them directly to form the block. Also, override CBlock's checks that assume the merkle root represents the full transaction hashes.
|
BTCC Pool has already tested this PR and submit valid blocks on testnet. Block #1035755 only contains coinbase transaction and #1035760 contains segwit transactions. Apart from these two blocks, all coinbase transaction contain the tag '/BTCC/' , meaning mined by BTCC Pool. |
|
Thank you for this PR! I'm watching segwit.co closely and if adoption rise near 50% (I hope so), I'll merge this. |
|
我没看明白你说的意思 你能简单的告诉我吗 你将合作？
At 2016-12-09 07:28:23, "slush0" <notifications@github.com> wrote:
Thank you for this PR! I'm watching segwit.co closely and if adoption rise near 50% (I hope so), I'll merge this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@slush0 FYI bitcoin 0.13.1 won't actually signal for SegWit activation without this patch so it would probably be a good idea to merge before hand. |
|
What @jameshilliard said. Pools can't (or shouldn't be) signaling for segwit until they advertise that they can actually produce valid blocks with witnesses. To be clear, this should have no negative effects on current mainnet mining, even before segwit activates. The commitment insertion is not harmful in either case. In fact, this PR currently required for using this software on testnet, where segwit is already active. Otherwise, gbt simply refuses to give it a template. |
|
Okay, done. Thanks! |
Adds support for requesting segwit support in gbt calls, as well as the necessary commitment insertion.
Commitments will be inserted even before segwit activation, so it's possible to verify that the insertion works far in advance.
Compares the calculated commitment to the one provided by bitcoind, if present, as an extra sanity check.