fix: double escaping (libxmljs#8)

sluukkonen · Oct 30, 2019 · edd08d8 · edd08d8
1 parent 60afe06
commit edd08d8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/xml_text.cc b/src/xml_text.cc
@@ -39,13 +39,7 @@ NAN_METHOD(XmlText::New)
   Nan::Utf8String contentRaw(contentOpt);
   const char *content = (contentRaw.length()) ? *contentRaw : NULL;
 
-  xmlChar *encodedContent = content ? xmlEncodeSpecialChars(document->xml_obj, (const xmlChar *)content) : NULL;
-
-  xmlNode *textNode = xmlNewDocText(document->xml_obj, encodedContent);
-  if (encodedContent)
-  {
-    xmlFree(encodedContent);
-  }
+  xmlNode *textNode = xmlNewDocText(document->xml_obj, (const xmlChar *)content);
 
   XmlText *element = new XmlText(textNode);
   textNode->_private = element;

diff --git a/test/text.js b/test/text.js
@@ -77,6 +77,16 @@ module.exports.addChild = function(assert) {
     assert.done();
 };
 
+module.exports.addChildEscaping = function(assert) {
+    var doc = libxml.parseXmlString("<p></p>");
+
+    doc.root().addChild(libxml.Text(doc, "x&x"));
+
+    assert.equal('<p>x&amp;x</p>', doc.root().toString());
+
+    assert.done();
+}
+
 module.exports.addSiblings = function(assert) {
     var doc = libxml.Document();
 
@@ -132,4 +142,3 @@ module.exports.add_next_sibling_merge_text = function(assert) {
 
   assert.done();
 };
-